Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 80.0.3987.116 to Chromium 80.0.3987.122 (1.4.x). #4729

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Upgrade from Chromium 80.0.3987.116 to Chromium 80.0.3987.122 (1.4.x). #4729

merged 1 commit into from
Feb 25, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 24, 2020 •
edited
Loading

Fixes brave/brave-browser#8379
Related PR: brave/brave-browser#8387
Uplift from #4723

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton @mkarolin
Merge pull request #4723 from brave/80.0.3987.122
9946444 
Upgrade from Chromium 80.0.3987.116 to Chromium 80.0.3987.122.
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Feb 24, 2020
@mkarolin mkarolin added this to the 1.4.x - Release milestone Feb 24, 2020
@mkarolin mkarolin requested a review from bridiver as a code owner February 24, 2020 23:00
@mkarolin mkarolin self-assigned this Feb 24, 2020
@mkarolin mkarolin mentioned this pull request Feb 24, 2020
Merged
29 tasks
@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 25, 2020
@kjozwiak
Copy link
Member

Restarting iOS due to build failing as per https://ci.brave.com/job/brave-browser-build-pr/job/PR-8387/2/execution/node/767/log/.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 25, 2020 •
edited
Loading

@bsclifton @mkarolin looks like iOS failed during the restart again due to https://ci.brave.com/job/brave-browser-build-pr/job/PR-8387/4/execution/node/318/log/.

Receiving objects:  44% (40009/90743), 34.61 MiB | 30.00 KiB/s   
22:26:34  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2429)
22:26:34  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:2043)
22:26:34  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)
22:26:34  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:568)
22:26:34  	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)
22:26:34  	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)
22:26:34  	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
22:26:34  	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
22:26:34  	at hudson.remoting.Request$2.run(Request.java:369)
22:26:34  	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
22:26:34  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
22:26:34  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
22:26:34  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
22:26:34  	at java.base/java.lang.Thread.run(Thread.java:834)
22:26:34  	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to mac-mini1-ky
22:26:34  		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
22:26:34  		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
22:26:34  		at hudson.remoting.Channel.call(Channel.java:998)
22:26:34  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
22:26:34  		at jdk.internal.reflect.GeneratedMethodAccessor844.invoke(Unknown Source)
22:26:34  		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
22:26:34  		at java.base/java.lang.reflect.Method.invoke(Method.java:566)
22:26:34  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
22:26:34  		at com.sun.proxy.$Proxy107.execute(Unknown Source)
22:26:34  		at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:906)
22:26:34  		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1123)
22:26:34  		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1159)
22:26:34  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)
22:26:34  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)
22:26:34  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)
22:26:34  		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
22:26:34  		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
22:26:34  		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
22:26:34  		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
22:26:34  		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
22:26:34  		at java.base/java.lang.Thread.run(Thread.java:834)

Going to try restarting it one more time to see if it's just an intermittent issue. iOS usually takes a few minutes to complete so restarting it is not as painful as macOS, Win and Linux.

bsclifton
bsclifton approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit af3a3ec into 1.4.x Feb 25, 2020
@bsclifton bsclifton deleted the 80.0.3987.122-1.4.x branch February 25, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@mkarolin mkarolin

Labels
CI/run-network-audit Run network-audit CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @kjozwiak @bsclifton